Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose + document the type coercion API publicly #3708

Closed
alamb opened this issue Oct 4, 2022 · 2 comments · Fixed by #3758
Closed

Expose + document the type coercion API publicly #3708

alamb opened this issue Oct 4, 2022 · 2 comments · Fixed by #3758
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Oct 4, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We programmatically make Exprs in IOx for specialized filters using the Expr API and want to create a PhysicalExpr. Prior to #3388, the coercion happened in physical exprs this was fine. Now that it happens earlier in the planning, I need a way to call it otherwise I see errors about types not matching in physical exprs

Describe the solution you'd like
I would like a public API that I can use to call the type coercion logic. This will likely help with #3582 as well.

Also I think it would be a good time to start documenting / providing examples of working with the DataFusion Expr APIs as they are quite powerful (e.g the rewrite rules are getting quite sophisticated)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Part of upgrading in https://github.com/influxdata/influxdb_iox/pull/5792

@alamb alamb added the enhancement New feature or request label Oct 4, 2022
@alamb alamb self-assigned this Oct 4, 2022
@alamb
Copy link
Contributor Author

alamb commented Oct 4, 2022

I plan to make a PR to fix this

@alamb
Copy link
Contributor Author

alamb commented Oct 7, 2022

The more I think about this, the more I think that coercion is mostly required for exrp simplification -- so I am thinking of ensuring type coercion is run prior to trying to simplify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant