Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove External Table Backwards Compatibility Options #8547

Closed
tustvold opened this issue Dec 14, 2023 · 3 comments · Fixed by #9105
Closed

Remove External Table Backwards Compatibility Options #8547

tustvold opened this issue Dec 14, 2023 · 3 comments · Fixed by #9105
Labels
enhancement New feature or request

Comments

@tustvold
Copy link
Contributor

tustvold commented Dec 14, 2023 •
edited
Loading

Is your feature request related to a problem or challenge?

#8539 and #8017 made various CREATE EXTERNAL TABLE options do nothing, but avoided making them return an error if specified so as to preserve backwards compatibility.

Describe the solution you'd like

We should remove this backwards compatibility logic

Describe alternatives you've considered

No response

Additional context

#8540 and #8548 will likely remove further options
@tustvold tustvold added the enhancement New feature or request label Dec 14, 2023
@tustvold tustvold mentioned this issue Dec 14, 2023
Merged
@alamb alamb mentioned this issue Dec 14, 2023
Open
38 tasks
@yyy1000
Copy link
Contributor

yyy1000 commented Feb 1, 2024 •
edited
Loading

Can I help this?
It seems a code clean task about removing insert_mode option.
Edit: and also create_local_path

@alamb
Copy link
Contributor

alamb commented Feb 1, 2024

Seems reasonable to me -- @tustvold do you have any other hints?

@yyy1000 yyy1000 mentioned this issue Feb 2, 2024
Merged
@yyy1000
Copy link
Contributor

yyy1000 commented Feb 2, 2024

Created #9105 that may help it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove External Table Backwards Compatibility Options yyy1000/arrow-datafusion
3 participants
@alamb @tustvold @yyy1000