Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: remove tokio_stream dependency #6565

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 6, 2023

Draft as it Builds on #6507

Which issue does this PR close?

N/A

Rationale for this change

We don't really use this crate, so we can reduce the dependnecy load of DataFusion

What changes are included in this PR?

Now that I know enough futures fu to do so, RecordBatchReceiverStream be easily be replaced with futures::stream::unfold

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

No

@alamb alamb force-pushed the alamb/remove_tokio_stream branch from bd21382 to 9f1f104 Compare June 6, 2023 19:39
@alamb alamb marked this pull request as ready for review June 6, 2023 19:51
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

@alamb alamb merged commit ce76f1b into apache:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants