Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Datasource]It is unnecessary to check the validity when saving the data source #12896

Closed
2 of 3 tasks
lenboo opened this issue Nov 14, 2022 · 4 comments · Fixed by #12900
Closed
2 of 3 tasks

[Improvement][Datasource]It is unnecessary to check the validity when saving the data source #12896

lenboo opened this issue Nov 14, 2022 · 4 comments · Fixed by #12900
Assignees
@DarkAssassinator
Labels
backend improvement make more easy to user or prompt friendly

Comments

@lenboo
Copy link
Contributor

lenboo commented Nov 14, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

It is unnecessary to check the validity when saving the data source.

Eg:
The datasource is only open to the specified worker, but we cannot connect it from API-SERVER.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@lenboo lenboo added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Nov 14, 2022
@github-actions
Copy link

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@SbloodyS SbloodyS added help wanted Extra attention is needed backend and removed Waiting for reply Waiting for reply labels Nov 14, 2022
@DarkAssassinator
Copy link
Contributor

+1 i will improve it.

@insist777 insist777 mentioned this issue Nov 15, 2022
Merged
@SbloodyS SbloodyS removed the help wanted Extra attention is needed label Nov 17, 2022
@caishunfeng
Copy link
Contributor

+1 i will improve it.

@DarkAssassinator I had merged the pr 🥲
@insist777 next time please leave the comment before submitting pr.

@DarkAssassinator
Copy link
Contributor

+1 i will improve it.

@DarkAssassinator I had merged the pr 🥲 @insist777 next time please leave the comment before submitting pr.

@caishunfeng , sure, welcome anyone to help fix issues.
@insist777 thx bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarkAssassinator DarkAssassinator

Labels
backend improvement make more easy to user or prompt friendly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[improve]Source skip check insist777/dolphinscheduler
4 participants
@caishunfeng @SbloodyS @DarkAssassinator @lenboo