Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [WorkerGroup] When deploying through 3.1.4 helm, setting WORKER_GROUPS and WORKER_GROUPS_0 in work env in values.yaml has no effect #13666

Closed
2 of 3 tasks
qin-sy opened this issue Mar 3, 2023 · 6 comments
Assignees
Labels
backend bug Something isn't working

Comments

@qin-sy
Copy link

qin-sy commented Mar 3, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

当我在k8s中部署worker时不能将worker注册到指定的workergroup中。

What you expected to happen

期望当我修改WORKER_GROUPS中的分组时可以在启动时注册到我指定的workergroup中。
当我在k8s中部署多个worker 的 StatefulSet 时,希望可以将不同的 StatefulSet 中的 POD 使用不同的分组管理。

现在启动时只能注册到默认的default中。
当我创建新的workergroup时,只能选择已经注册到default中的woker,
当 StatefulSet 中的POD增加或者减少时,需要人工修改workergroup中的设置。

How to reproduce

使用3.1.4版本的 helm 配置文件
修改WORKER_GROUPS、WORKER_GROUPS_0中的分组后部署到k8s中后在画面中查看workgroup

Anything else

No response

Version

3.1.x

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@qin-sy qin-sy added bug Something isn't working Waiting for reply Waiting for reply labels Mar 3, 2023
@github-actions github-actions bot changed the title [Bug] [WorkerGroup] 通过3.1.4的helm部署时、设置values.yaml中work env中的WORKER_GROUPS和WORKER_GROUPS_0没有作用 [Bug] [WorkerGroup] When deploying through 3.1.4 helm, setting WORKER_GROUPS and WORKER_GROUPS_0 in work env in values.yaml has no effect Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

When I deploy a worker in k8s, I cannot register the worker to the specified workergroup.

What you expected to happen

It is expected that when I modify the grouping in WORKER_GROUPS, I can register to the workergroup I specified at startup.
When I deploy multiple worker StatefulSets in k8s, I hope that the PODs in different StatefulSets can be managed in different groups.

Now it can only be registered to the default default at startup.
When I create a new workergroup, I can only choose wokers that have been registered in the default,
When the POD in the StatefulSet increases or decreases, it is necessary to manually modify the settings in the workergroup.

How to reproduce

Use the helm configuration file for version 3.1.4
After modifying the groups in WORKER_GROUPS and WORKER_GROUPS_0 and deploying them to k8s, view the workgroup on the screen

Anything else

No response

Version

3.1.x

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information, version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@zhuangchong zhuangchong added this to the 3.1.5 milestone Mar 3, 2023
@EricGao888
Copy link
Member

@qin-sy Hello, if u deploy DS through helm, the environment variable WORKER_GROUPS will take effect for you workers. Could u explain in details how you add more different statefulsets? Have u injected the environment variables defined in values.yaml?

env:
WORKER_GROUPS_0: default
WORKER_MAX_CPU_LOAD_AVG: "-1"
WORKER_RESERVED_MEMORY: "0.3"
WORKER_EXEC_THREADS: "100"
WORKER_HEARTBEAT_INTERVAL: "10s"
WORKER_HEART_ERROR_THRESHOLD: "5"
WORKER_HOST_WEIGHT: "100"
WORKER_GROUPS: "default"

BTW, could u plz use English for issue description in the future? Thx.

@EricGao888 EricGao888 added question Further information is requested and removed bug Something isn't working Waiting for reply Waiting for reply labels Mar 7, 2023
@EricGao888 EricGao888 removed this from the 3.1.5 milestone Mar 7, 2023
@qin-sy
Copy link
Author

qin-sy commented Mar 8, 2023

@EricGao888
在3.1.0的版本中修改WORKER_GROUPS内容可以自动创建指定分组。
3.1.4版本不行。3.1.4版本只会在default分组中添加worker。

google translate:
Modifying the content of WORKER_GROUPS in version 3.1.0 can automatically create specified groups. Version 3.1.4 does not work. Version 3.1.4 will only add workers to the default group。

 env: 
-  WORKER_GROUPS_0: default 
   WORKER_MAX_CPU_LOAD_AVG: "-1" 
   WORKER_RESERVED_MEMORY: "0.3" 
   WORKER_EXEC_THREADS: "100" 
   WORKER_HEARTBEAT_INTERVAL: "10s" 
   WORKER_HEART_ERROR_THRESHOLD: "5" 
   WORKER_HOST_WEIGHT: "100" 
-  WORKER_GROUPS: "default" 
+  WORKER_GROUPS: "another-works" 

3.1.0:
image

@Radeity
Copy link
Member

Radeity commented Mar 10, 2023

Hi, @qin-sy , we don't maintain worker group in registry since 3.1.4 (related issue: #12157), you can config them in UI page by yourself and worker group info will be stored in db.

@Radeity
Copy link
Member

Radeity commented Mar 10, 2023

@qin-sy Hello, if u deploy DS through helm, the environment variable WORKER_GROUPS will take effect for you workers. Could u explain in details how you add more different statefulsets? Have u injected the environment variables defined in values.yaml?

env:
WORKER_GROUPS_0: default
WORKER_MAX_CPU_LOAD_AVG: "-1"
WORKER_RESERVED_MEMORY: "0.3"
WORKER_EXEC_THREADS: "100"
WORKER_HEARTBEAT_INTERVAL: "10s"
WORKER_HEART_ERROR_THRESHOLD: "5"
WORKER_HOST_WEIGHT: "100"
WORKER_GROUPS: "default"

BTW, could u plz use English for issue description in the future? Thx.

Hi, @EricGao888 , this configuration in values.yaml may be outdated, environment variable WORKER_GROUP is useless in the latest version, i can create a PR to remove them.

@SbloodyS SbloodyS added bug Something isn't working backend and removed question Further information is requested labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants