Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](Job)The INSERT execution failed, but the task record status is marked as successful. #44292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Nov 19, 2024

What problem does this PR solve?

After a job execution is completed, we need to verify whether the QueryState is normal.
Currently, we rely on exception handling to determine success. However, in certain cases, such as execution timeouts, exceptions may not be captured. As a result, the status is incorrectly marked as successful.

Release note

None

Check List (For Author)

  • Test
    • Manual test (add detailed scripts or steps below)
select * from tasks('type'='insert') ;


+----------------+----------------+---------+-------------------------------+---------+----------------------------------------------+---------------------+---------------------+------------+-------------+---------------+------+
| TaskId         | JobId          | JobName | Label                         | Status  | ErrorMsg                                     | CreateTime          | StartTime           | FinishTime | TrackingUrl | LoadStatistic | User |
+----------------+----------------+---------+-------------------------------+---------+----------------------------------------------+---------------------+---------------------+------------+-------------+---------------+------+
| 53767413936871 | 53748267972932 | test    | 53748267972932_53767413936871 | RUNNING |                                              | 2024-11-19 21:39:46 | 2024-11-19 21:39:46 |            |             |               | root |
| 53758617801828 | 53748267972932 | test    | 53748267972932_53758617801828 | FAILED  | errCode = 2, detailMessage = Execute timeout | 2024-11-19 21:39:37 | 2024-11-19 21:39:37 |            |             |               | root |

  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…er the QueryState is normal.

### backend
Currently, we rely on exception handling to determine success. However, in certain cases, such as execution timeouts, exceptions may not be captured. As a result, the status is incorrectly marked as successful.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs
Copy link
Member Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants