-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](code-style)add spotless plugin #25033
Conversation
run buildall |
1 similar comment
run buildall |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does new checker's rules TOTALLY same as original checkstyle rules? if not same, please desc what different between two of them. there are too many check to avoid wrong code and ensure easy reading in checkstyle rules, u should impl all of them in new checker before remove checkstyle rules.
furthermore, u should explain the purpose of replacing spotless with checkstyle
Other rules can use spotless directly. If you have any other verification rules that you are interested in, please send them to me. |
checkstyle is not just for code format check. it is also check some code logic check. for example,
does spotless do same check now? |
# Conflicts: # fe/pom.xml
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
This reverts commit d088cba.
Proposed changes
https://lists.apache.org/thread/x0r5lndj1b0dxypm3v2k0dnkvl416szl
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...