Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ehancement: upgrade gRPC version from 1.26 to 1.36 #1152

Closed
AlexStocks opened this issue Apr 12, 2021 · 5 comments
Closed

Ehancement: upgrade gRPC version from 1.26 to 1.36 #1152

AlexStocks opened this issue Apr 12, 2021 · 5 comments
Assignees

Comments

@AlexStocks
Copy link
Contributor

What would you like to be added:

upgrade gRPC version.

Why is this needed:

using latest gRPC.

@AlexStocks
Copy link
Contributor Author

cc @gaoxinge

@gaoxinge gaoxinge self-assigned this Apr 13, 2021
@gaoxinge
Copy link

I think the difficult thing is that we should upgrade the version of etcd. This is because etcd does not use go module before v3.5.0 ([1], [2]).

Now the latest version of github.com/coreos/etcd is v3.3.25+incompatible ([3]), and highest compatible version of grpc is v1.26.0. So we can not directly upgrade grpc to higher version.

In addition, github.com/coreos/etcd@v3.5.0 will release in the mid of 2021 ([4]), and it may introduce incompatible and conflict codes with dubbogo.

@AlexStocks
Copy link
Contributor Author

I think the difficult thing is that we should upgrade the version of etcd. This is because etcd does not use go module before v3.5.0 ([1], [2]).

Now the latest version of github.com/coreos/etcd is v3.3.25+incompatible ([3]), and highest compatible version of grpc is v1.26.0. So we can not directly upgrade grpc to higher version.

In addition, github.com/coreos/etcd@v3.5.0 will release in the mid of 2021 ([4]), and it may introduce incompatible and conflict codes with dubbogo.

ok. I got what u said. let's keep this issue until the autumn of 2021.

we just upgrade gRPC to 1.26 now.

@gaoxinge
Copy link

gaoxinge commented May 14, 2021

I have updated grpc from 1.26.0 to 1.29.1. I will try to update it to 1.36 later. @AlexStocks

@gaoxinge gaoxinge reopened this May 14, 2021
@gaoxinge
Copy link

#1203 have updated etcd and grpc to latest version and it still needs

google.golang.org/grpc => google.golang.org/grpc v1.29.1

because of the consul depends the grpc v1.15.1.

But I think we can slow down the pace to update the verion of grpc, and focus on other issues. @AlexStocks @ztelur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants