Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set the common getty params #1340

Closed
AlexStocks opened this issue Jul 24, 2021 · 4 comments · Fixed by #1345
Closed

set the common getty params #1340

AlexStocks opened this issue Jul 24, 2021 · 4 comments · Fixed by #1345

Comments

@AlexStocks
Copy link
Contributor

AlexStocks commented Jul 24, 2021 •
edited
Loading

What would you like to be added:

1 升级 getty 版本到 1.4.4
2 当前 getty 一些 session 参数如下
image

2.1 需要删除上面红线出过时的参数，也许还有其他一些过时参数，请参阅最新 getty ；
2.2 需要把 getty 配置参数公共化，不要让用户不断反复配置；
@AlexStocks
Copy link
Contributor Author

cc @djh

@Mulavar Mulavar mentioned this issue Jul 27, 2021
Merged
@Mulavar
Copy link
Member

Mulavar commented Aug 5, 2021

关于2.2，和云兴大哥讨论了下，如果用户既用了triple又用了dubbo，那两者底层的网络配置应该是各有一套，云兴大哥在调研配置优化的时候看了dubbo的实现也是这样的，所以我们觉得2.2是不是还是先保留现状。

@AlexStocks
Copy link
Contributor Author

关于2.2，和云兴大哥讨论了下，如果用户既用了triple又用了dubbo，那两者底层的网络配置应该是各有一套，云兴大哥在调研配置优化的时候看了dubbo的实现也是这样的，所以我们觉得2.2是不是还是先保留现状。

ok

@LaurenceLiZhixin
Copy link
Contributor

Can this pr be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/upgrade getty Mulavar/dubbo-go
3 participants
@AlexStocks @Mulavar @LaurenceLiZhixin