Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentinel-golang error on windows #795

Closed
kennethkongiw opened this issue Oct 16, 2020 · 1 comment · Fixed by #821
Closed

sentinel-golang error on windows #795

kennethkongiw opened this issue Oct 16, 2020 · 1 comment · Fixed by #821
Labels
bug Something isn't working
Milestone
v1.5.4

Comments

@kennethkongiw
Copy link

kennethkongiw commented Oct 16, 2020 •
edited
Loading

dubbo-go version: v1.5.3

github.com/alibaba/sentinel-golang depends on github.com/shirou/gopsutil, but the load.Avg() method of it is not implemented on windows, resulting the following error after init.

image

image
@binbin0325
Copy link
Member

@kennethkongiw Yes, sentinel-golang currently uses gopsutil, and gopsutil doesn't support windows load yet.
sentinel-golang is working on a solution.

@AlexStocks AlexStocks mentioned this issue Oct 20, 2020
Closed
@zouyx zouyx linked a pull request Oct 30, 2020 that will close this issue
fix sentinel windows issue #821
Merged
@zouyx zouyx added this to the v1.5.4 milestone Oct 30, 2020
@zouyx zouyx added the bug Something isn't working label Oct 30, 2020
@zouyx zouyx closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging a pull request may close this issue.

fix sentinel windows issue louyuting/dubbo-go
3 participants
@zouyx @kennethkongiw @binbin0325