feat: support json protocol with grpc #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
- Coverage 67.41% 66.72% -0.69%
==========================================
Files 174 175 +1
Lines 9261 9283 +22
==========================================
- Hits 6243 6194 -49
- Misses 2416 2484 +68
- Partials 602 605 +3
Continue to review full report at Codecov.
|
xujianhai666
changed the title
xujianhai666
changed the title
- add client conf - support json codec Closes apache#436
xujianhai666
force-pushed
the
feat-grpc-json
branch
from
f45f679 to
cb259e9
Compare
flycash
reviewed
Mar 31, 2020
| } | ||
| } | ||
| clientConf = &defaultClientConfig | ||
| if err := clientConf.Validate(); err != nil { |
There was a problem hiding this comment.
It seems that the clientConfg always return nil.
| } | ||
| } | ||
|
|
||
| func (c *ClientConfig) Validate() error { |
There was a problem hiding this comment.
Always return nil? Should we check the ContentType?
zouyx
reviewed
Apr 2, 2020
| conn, err := grpc.Dial(url.Location, grpc.WithInsecure(), grpc.WithBlock(), | ||
| grpc.WithUnaryInterceptor( | ||
| otgrpc.OpenTracingClientInterceptor(tracer, otgrpc.LogPayloads()))) | ||
| dailOpts := make([]grpc.DialOption, 0) |
There was a problem hiding this comment.
Suggested change
| dailOpts := make([]grpc.DialOption, 0) | |
| dailOpts := make([]grpc.DialOption, 0,n) |
specify capacity as above
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package grpc |
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package grpc |
|
why merge to master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #436