Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling timeouts and network timeouts separately #3060

Closed
2 tasks done
HouZhiHouJue opened this issue Dec 26, 2018 · 3 comments
Closed
2 tasks done

Handling timeouts and network timeouts separately #3060

HouZhiHouJue opened this issue Dec 26, 2018 · 3 comments
Labels
type/proposal Everything you want Dubbo have

Comments

@HouZhiHouJue
Copy link

HouZhiHouJue commented Dec 26, 2018

There is a difference between timeout and network timeout. In FailoverClusterInvoker, whether it is timeout or network timeout, it is ignored. If it is a business timeout, then two retry attempts will cause an avalanche effect. In FailfastClusterInvoker, there is no fault tolerance for network timeouts. If it is a network partition, the SLA will inevitably fall. I think the implementation of these two Invokers must include the processing of the network timeout, otherwise the implementation is not correct.

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.6.5
  • Operating System version: centos 7.2
  • Java version: 1.8

Steps to reproduce this issue

  1. xxx
  2. xxx
  3. xxx

Pls. provide [GitHub address] to reproduce this issue.

Expected Result

What do you expected from the above steps?

Actual Result

What actually happens?

If there is an exception, please attach the exception trace:

Just put your stack trace here!
@lexburner
Copy link
Contributor

A nice suggestion to me.

@Kiddinglife
Copy link

@HouZhiHouJue I think you are right. I posted another issue which looks similar to your one. the dubbo has provided the upper user the exact error code for different failing reasons. you can go there and check if there is the one you are looking forward to.
issue
regards.

@AlbumenJ AlbumenJ added the type/proposal Everything you want Dubbo have label May 23, 2021
@CrazyHZM
Copy link
Member

No feedback for a long time, please close the issue temporarily. If there is still a problem, you can reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal Everything you want Dubbo have
Projects
None yet
Development

No branches or pull requests

5 participants