Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericService泛化调用使用oninvoke、onreturn、onthrow时,FutureFilter的invocation.getMethodName()无法正确返回 #3408

Closed
2 tasks done
xiangxiuhui opened this issue Jan 31, 2019 · 3 comments · Fixed by #3528
Assignees

Comments

@xiangxiuhui
Copy link

xiangxiuhui commented Jan 31, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.6.4

Steps to reproduce this issue

  1. GenericService泛化调用
  2. 使用oninvoke、onreturn、onthrow
  3. FutureFilter无法正常回调

Expected Result

StaticContext.getKey(invoker.getUrl(), invocation.getMethodName(), Constants.ON_INVOKE_METHOD_KEY)
返回
com.alibaba.boot.dubbo.demo.consumer.DemoService:1.0.0.sayHello.oninvoke.method

Actual Result

StaticContext.getKey(invoker.getUrl(), invocation.getMethodName(), Constants.ON_INVOKE_METHOD_KEY)
返回
com.alibaba.boot.dubbo.demo.consumer.DemoService:1.0.0.$invoke.oninvoke.method

预期是:

        String methodName = invocation.getMethodName();
        if("$invoke".equals(methodName)) {
            Object[] arguments = invocation.getArguments();
            methodName = (String) arguments[0];
        }
@tswstarplanet tswstarplanet added status/waiting-for-feedback Need reporters to triage and removed status/waiting-for-feedback Need reporters to triage labels Jan 31, 2019
@tswstarplanet tswstarplanet self-assigned this Jan 31, 2019
@tswstarplanet
Copy link
Contributor

Thank you! I will fix this bug in 2.6.x version

@chickenlj
Copy link
Contributor

@tswstarplanet Have you confirmed this issue? Would you please also submit one to 2.7.x?

@tswstarplanet
Copy link
Contributor

I debugged it on 2.6.x, it indeedly have problems.
The corresponding code on 2.7.x is refactored. So I will confirm if there are problems, if so, I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants