Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter problems in async way #3483

Closed
carryxyh opened this issue Feb 15, 2019 · 1 comment
Closed

Filter problems in async way #3483

carryxyh opened this issue Feb 15, 2019 · 1 comment
Assignees
Milestone

Comments

@carryxyh
Copy link
Member

Recently, I found that dubbo does not handle the data generated during the call process when it is asynchronous.

For example, in TimeoutFilter, we used invocation#attachments to hold the data that needs to be passed (start time in TimeoutFilter). But I don't think this way is good, although using Invocation.attachments to pass data does not pollute RpcContext.

Perhaps a better way is to add a temporary attachment to the Invocation that only maintains the temporary data generated during the call.

In addition, I found that we still have a few Filters that are currently problematic in asynchronous scenarios, such as:

  • ActiveLimitFilter
  • TraceFilter

We should determine a plan as soon as possible and then proceed to fix these Filters.

@carryxyh carryxyh self-assigned this Feb 15, 2019
@chickenlj chickenlj added this to the 2.7.1 milestone Feb 18, 2019
@Leishunyu
Copy link
Contributor

I will follow up and fix this issue in the future.

@cvictory cvictory modified the milestones: 2.7.1, 2.7.2 Mar 14, 2019
@chickenlj chickenlj self-assigned this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants