Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Service #3702

Closed
wants to merge 0 commits into from
Closed

Metrics Service #3702

wants to merge 0 commits into from

Conversation

panxiaojun233
Copy link
Contributor

What is the purpose of the change

By exposing Dubbo's built-in service, Dubbo-admin can collect data from Metrics statistics.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@nzomkxia nzomkxia added this to the 2.7.2 milestone Mar 20, 2019
@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #3702 into master will increase coverage by 0.18%.
The diff coverage is 59.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3702      +/-   ##
============================================
+ Coverage     63.46%   63.64%   +0.18%     
  Complexity       71       71              
============================================
  Files           703      704       +1     
  Lines         31002    31046      +44     
  Branches       5023     5025       +2     
============================================
+ Hits          19675    19759      +84     
+ Misses         9060     9016      -44     
- Partials       2267     2271       +4
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/apache/dubbo/common/Constants.java 93.33% <ø> (ø) 0 <0> (ø) ⬇️
...bo/config/spring/schema/DubboNamespaceHandler.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...in/java/org/apache/dubbo/config/MetricsConfig.java 18.18% <18.18%> (ø) 0 <0> (?)
...in/java/org/apache/dubbo/config/ServiceConfig.java 56.58% <56.58%> (+0.09%) 0 <0> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 61.23% <61.23%> (+0.14%) 0 <0> (ø) ⬇️
.../org/apache/dubbo/monitor/dubbo/MetricsFilter.java 80.82% <78.12%> (ø) 0 <0> (?)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.46% <0%> (-1.54%) 0% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660624c...cffbfe9. Read the comment docs.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are changes that are irrelavant (CRLF and LF) in some files:
ReferenceConfig.java, ServiceConfig.java, and DubboNamespaceHandler.java (and maybe others). @panxiaojun233 could you please revert the irrelavant changes?

@nzomkxia nzomkxia closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants