Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty protocol in consul registry. #4294 #4354

Merged
merged 3 commits into from
Jun 26, 2019

Conversation

cvictory
Copy link
Contributor

#4294

consul empty protocol

@cvictory cvictory requested a review from chickenlj June 20, 2019 03:38
@codecov-io
Copy link

Codecov Report

Merging #4354 into master will increase coverage by 0.04%.
The diff coverage is 78.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4354      +/-   ##
===========================================
+ Coverage     62.85%   62.9%   +0.04%     
- Complexity      449     452       +3     
===========================================
  Files           769     769              
  Lines         32995   33004       +9     
  Branches       5215    5215              
===========================================
+ Hits          20740   20761      +21     
+ Misses         9849    9841       -8     
+ Partials       2406    2402       -4
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/registry/consul/ConsulRegistry.java 61.87% <78.57%> (+2.27%) 29 <3> (+2) ⬆️
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-0.95%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 81.6% <0%> (+1.53%) 0% <0%> (ø) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 86.2% <0%> (+3.44%) 0% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 62.35% <0%> (+4.7%) 21% <0%> (+1%) ⬆️
.../apache/dubbo/remoting/transport/AbstractPeer.java 71.73% <0%> (+8.69%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c9d9d...b8e05d2. Read the comment docs.

@chickenlj chickenlj changed the base branch from master to 2.7.3-release June 26, 2019 02:24
@chickenlj chickenlj merged commit 6b7d118 into apache:2.7.3-release Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants