-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(state): add emphasis.disabled #16368
Conversation
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plainheart Seems it's introduced by gradient color highlight and animation in #16225 and ecomfe/zrender#857 . Will take a look at it |
@plainheart Turns out it's a very stupid typo. ecomfe/zrender#872 . Also added a interaction record for this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Introduce
emphasis.disabled
to disable emphasis state on hover and tooltip trigger.Previously
we can only usesilent
to disable any hover interactions. But it will also lost the mouse event.By disabling
emphasis
state. We can avoid potential performance issue when interacting with massive data like in #16133 . Or remove unwanted highlight / emphasis effect like in #14952Also ee related
select.disabled
PR by @susiwen8 .Fixed issues
#14952
Misc
Related test cases or examples to use the new APIs
Disable emphasis state of whole series
Disable emphasis state of single data
Disable emphasis state in custom series
Others
Merging options
Other information