Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): fix the abandoned normal level in the theme file #17482

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

Liangism
Copy link

@Liangism Liangism commented Aug 8, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 8, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@plainheart plainheart linked an issue Aug 8, 2022 that may be closed by this pull request
@plainheart plainheart added this to the 5.4 milestone Aug 8, 2022
@plainheart plainheart changed the title fix(theme): fix the abandoned normal level in the theme file. close #… fix(theme): fix the abandoned normal level in the theme file Aug 8, 2022
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, it looks good to me. Left several minor issues.

theme/macarons2.js Outdated Show resolved Hide resolved
theme/macarons2.js Outdated Show resolved Hide resolved
@plainheart plainheart requested a review from Ovilia August 8, 2022 06:57
Ovilia
Ovilia previously approved these changes Aug 8, 2022
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your contribution!

@plainheart plainheart merged commit abd40cc into apache:master Aug 9, 2022
@echarts-bot
Copy link

echarts-bot bot commented Aug 9, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia modified the milestones: 5.4, 5.4.0 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 5.3.3版本使用主题文件出现警告信息
3 participants