Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure compatibility with typescript@4.8 #17582

Merged
merged 3 commits into from
Sep 1, 2022
Merged

fix: ensure compatibility with typescript@4.8 #17582

merged 3 commits into from
Sep 1, 2022

Conversation

AviVahl
Copy link
Contributor

@AviVahl AviVahl commented Aug 27, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Allows using echarts with newly released ts@4.8, when .d.ts are being checked.

Fixed issues

fixes #17581

Details

Before: What was the problem?

See #17581

After: How does it behave after the fixing?

Passes type checking

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 27, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

pissang
pissang previously approved these changes Aug 31, 2022
@pissang pissang changed the base branch from master to release August 31, 2022 14:28
@pissang pissang dismissed their stale review August 31, 2022 14:28

The base branch was changed.

@pissang pissang merged commit b9f330b into apache:release Sep 1, 2022
@echarts-bot
Copy link

echarts-bot bot commented Sep 1, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang added this to the 5.4 milestone Sep 1, 2022
@Ovilia Ovilia modified the milestones: 5.4, 5.4.0 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] type error with typescript 4.8
4 participants