Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polar): support borderRadius for polar bars #17980 #17995

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Nov 30, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

support borderRadius for polar bars

Fixed issues

#17980

Details

Before: What was the problem?

itemStyle.borderRadius is not supported for polar bars.

After: How does it behave after the fixing?

itemStyle.borderRadius is supported like Sunburst or Pie charts.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Nov 30, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@Ovilia Ovilia added this to the 5.5.0 milestone Nov 30, 2022
hexiaokang
hexiaokang previously approved these changes Dec 5, 2022
@Ovilia Ovilia modified the milestones: 5.5.0, 5.4.2 Mar 3, 2023
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And should we also support borderRadius for the background sector?

if (coord.type === 'cartesian2d') {
(bgEl as Rect).setShape('r', barBorderRadius);
}

if (coord.type === 'cartesian2d') {
(bgEl as Rect).setShape('r', barBorderRadius);
}

src/chart/bar/BarView.ts Outdated Show resolved Hide resolved
src/chart/bar/BarView.ts Outdated Show resolved Hide resolved
@plainheart
Copy link
Member

Merging latest master branch into this branch can solve the lint action error.

@echarts-bot
Copy link

echarts-bot bot commented Mar 6, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] borderRadius not working for polar bars
3 participants