-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(polar): support borderRadius for polar bars #17980 #17995
Conversation
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And should we also support borderRadius
for the background sector?
echarts/src/chart/bar/BarView.ts
Lines 246 to 248 in 5667432
if (coord.type === 'cartesian2d') { | |
(bgEl as Rect).setShape('r', barBorderRadius); | |
} |
echarts/src/chart/bar/BarView.ts
Lines 337 to 339 in 5667432
if (coord.type === 'cartesian2d') { | |
(bgEl as Rect).setShape('r', barBorderRadius); | |
} |
Merging latest master branch into this branch can solve the lint action error. |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
support borderRadius for polar bars
Fixed issues
#17980
Details
Before: What was the problem?
itemStyle.borderRadius
is not supported for polar bars.After: How does it behave after the fixing?
itemStyle.borderRadius
is supported like Sunburst or Pie charts.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information