Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): allow passing null to the parameters of init function #18575

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

zhuscat
Copy link
Contributor

@zhuscat zhuscat commented Apr 27, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

update init function type signature so it can be identical to official document

Fixed issues

According to the official document, we can pass null to the first or the second parameter. However, the type signature disallow pass null

https://echarts.apache.org/handbook/en/best-practices/canvas-vs-svg/

https://echarts.apache.org/handbook/en/how-to/cross-platform/server/#server-side-rendering

image

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Apr 27, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@plainheart plainheart changed the title update init function type signature so it can be identical to document fix(type): allow passing null to the parameters of init function Apr 28, 2023
@plainheart plainheart merged commit 8b08773 into apache:master Apr 28, 2023
@echarts-bot
Copy link

echarts-bot bot commented Apr 28, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants