Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): add missing callback function type for series-tree.symbol #18070

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix(type): add missing callback function type for series-tree.symbol #18070

merged 1 commit into from
Dec 16, 2022

Conversation

ChepteaCatalin
Copy link
Contributor

@ChepteaCatalin ChepteaCatalin commented Dec 15, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix typescript error when providing a callback to the symbol property of the tree series. Close #17946

Details

Before: What was the problem?

When providing a callback to the symbol property of the tree series, the following typescript error appeared:

image

Callback function itself was working, but type definition was wrong.

This was happening because TreeSeriesOption extended SymbolOptionMixin instead of SymbolOptionMixin<CallbackDataParams> interface.

After: How does it behave after the fixing?

Now it is possible to provide a callback to the tree series symbol without typescript errors.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 15, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@Ovilia Ovilia merged commit 6be45ba into apache:master Dec 16, 2022
@echarts-bot
Copy link

echarts-bot bot commented Dec 16, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart changed the title fix(tree): change symbol type. close #17946 fix(type): add missing callback function type for series-tree.symbol Dec 16, 2022
@plainheart plainheart added this to the 5.5.0 milestone Dec 16, 2022
@ChepteaCatalin ChepteaCatalin deleted the fix-17946 branch December 16, 2022 07:08
@Ovilia Ovilia modified the milestones: 5.5.0, 5.4.2 Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Callback for series-tree.symbol not defined in typescript
3 participants