Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(labelLine): fix emphasis.labelLine is not working in pie chart #19180

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

shiersansi
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

solved problem:emphasis.labelLine not work in pie chart #19160

Fixed issues

https://github.com/apache/echarts/issues/19160
#19160

Details

Before: What was the problem?

label lines are not hidden when emphasis

After: How does it behave after the fixing?

When I select the blue section,label lines are hidden when emphasis

0-09 161011

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 9, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failed test case in the CI and run visual tests of all cases to make sure it doesn't break any changes. Please also note that #18800 was also trying to fix the same problem. The first PR that finds the correct solution will be merged. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19180@ce9e51a

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint problems and this demo also fails.

@shiersansi
Copy link
Contributor Author

Please fix the lint problems and this demo also fails.

In this section of the code comment, it is mentioned that if label is false, labelLine will not be displayed. So, should we modify it to mean that lableLine will not be affected no matter what the label is

@Ovilia Ovilia merged commit 6ce4dbc into apache:master Oct 20, 2023
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Oct 20, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] emphasis.labelLine not work in pie chart
2 participants