From afaedbe3f5404c8f2d74c94e4fbf249059ace57d Mon Sep 17 00:00:00 2001 From: Urmi Mustafi Date: Tue, 17 Oct 2023 13:28:53 -0700 Subject: [PATCH] Update javadoc --- .../org/apache/gobblin/runtime/api/DagActionStore.java | 1 - .../gobblin/runtime/api/MultiActiveLeaseArbiter.java | 7 +++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/DagActionStore.java b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/DagActionStore.java index 91724256eca..eb26acd161a 100644 --- a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/DagActionStore.java +++ b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/DagActionStore.java @@ -54,7 +54,6 @@ public static DagActionStore.DagAction updateFlowExecutionId(DagActionStore.DagA return new DagActionStore.DagAction(flowAction.getFlowGroup(), flowAction.getFlowName(), String.valueOf(eventTimeMillis), flowAction.getFlowActionType()); } - } diff --git a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MultiActiveLeaseArbiter.java b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MultiActiveLeaseArbiter.java index ebd88064d83..253db49ba92 100644 --- a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MultiActiveLeaseArbiter.java +++ b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MultiActiveLeaseArbiter.java @@ -89,8 +89,7 @@ class LeaseObtainedStatus extends LeaseAttemptStatus { private final long leaseAcquisitionTimestamp; /** - * Returns event time in millis since epoch for the event of this lease acquisition. - * @return + * @return event time in millis since epoch for the event of this lease acquisition */ public long getEventTimeMillis() { return Long.parseLong(flowAction.getFlowExecutionId()); @@ -99,8 +98,8 @@ public long getEventTimeMillis() { /* This flow action event already has a valid lease owned by another participant. - `Flow action`'s flow execution id is the timestamp the lease is associated with, which may be a different timestamp - for the same flow action corresponding to the same instance of the event or a distinct one. + `Flow action`'s flow execution id is the timestamp the lease is associated with, however the flow action event it + corresponds to may be a different and distinct occurrence of the same event. `minimumLingerDurationMillis` is the minimum amount of time to wait before this participant should return to check if the lease has completed or expired */