From f84e1fc5bf43f9ff31491f4e8eebbc4da3614a37 Mon Sep 17 00:00:00 2001
From: YuLuo <yuluo08290126@gmail.com>
Date: Sun, 21 Jul 2024 21:03:37 +0800
Subject: [PATCH] [Improve] add unit test & fix some bugs (#2326)

Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
---
 .../support/valid/HostParamValidator.java     |  6 +-
 .../vaild/EmailParamValidatorTest.java        | 84 +++++++++++++++++++
 .../support/vaild/HostParamValidatorTest.java | 84 +++++++++++++++++++
 .../vaild/PhoneNumParamValidatorTest.java     | 75 +++++++++++++++++
 4 files changed, 247 insertions(+), 2 deletions(-)
 create mode 100644 common/src/test/java/org/apache/hertzbeat/common/support/vaild/EmailParamValidatorTest.java
 create mode 100644 common/src/test/java/org/apache/hertzbeat/common/support/vaild/HostParamValidatorTest.java
 create mode 100644 common/src/test/java/org/apache/hertzbeat/common/support/vaild/PhoneNumParamValidatorTest.java

diff --git a/common/src/main/java/org/apache/hertzbeat/common/support/valid/HostParamValidator.java b/common/src/main/java/org/apache/hertzbeat/common/support/valid/HostParamValidator.java
index c0e7deab344..a30e1c26a8a 100644
--- a/common/src/main/java/org/apache/hertzbeat/common/support/valid/HostParamValidator.java
+++ b/common/src/main/java/org/apache/hertzbeat/common/support/valid/HostParamValidator.java
@@ -34,11 +34,13 @@ public class HostParamValidator implements ConstraintValidator<HostValid, String
     @Override
     public boolean isValid(String value, ConstraintValidatorContext context) {
         if (value != null && value.toLowerCase().contains(HTTP)){
-            value = value.replaceAll(PATTERN_HTTP, BLANK);
+            value = value.replaceFirst(PATTERN_HTTP, BLANK);
         }
         if (value != null && value.toLowerCase().contains(HTTPS)){
-            value = value.replace(PATTERN_HTTPS, BLANK);
+            value = value.replaceFirst(PATTERN_HTTPS, BLANK);
         }
+
         return IpDomainUtil.validateIpDomain(value);
     }
+
 }
diff --git a/common/src/test/java/org/apache/hertzbeat/common/support/vaild/EmailParamValidatorTest.java b/common/src/test/java/org/apache/hertzbeat/common/support/vaild/EmailParamValidatorTest.java
new file mode 100644
index 00000000000..e0e512a677a
--- /dev/null
+++ b/common/src/test/java/org/apache/hertzbeat/common/support/vaild/EmailParamValidatorTest.java
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hertzbeat.common.support.vaild;
+
+import jakarta.validation.ConstraintValidatorContext;
+import org.apache.hertzbeat.common.support.valid.EmailParamValidator;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.when;
+
+/**
+ * Test case for {@link EmailParamValidator}
+ */
+
+class EmailParamValidatorTest {
+
+	@InjectMocks
+	private EmailParamValidator emailParamValidator;
+
+	@Mock
+	private ConstraintValidatorContext context;
+
+	@Mock
+	private ConstraintValidatorContext.ConstraintViolationBuilder constraintViolationBuilder;
+
+	@BeforeEach
+	public void setUp() {
+		MockitoAnnotations.initMocks(this);
+		when(context.buildConstraintViolationWithTemplate(any())).thenReturn(constraintViolationBuilder);
+	}
+
+	@Test
+	public void testIsValid() {
+		boolean result = emailParamValidator.isValid(null, context);
+		assertFalse(result);
+
+		result = emailParamValidator.isValid("123456345@qq.com", context);
+		assertTrue(result);
+
+		result = emailParamValidator.isValid("", context);
+		assertFalse(result);
+
+		result = emailParamValidator.isValid("   ", context);
+		assertFalse(result);
+
+		result = emailParamValidator.isValid("test@example.com", context);
+		assertTrue(result);
+
+		result = emailParamValidator.isValid("test@example", context);
+		assertFalse(result);
+
+		result = emailParamValidator.isValid("test@sub.example.com", context);
+		assertTrue(result);
+
+
+		String longEmail = "verylongemailaddress@subdomain.domain.example.com";
+		result = emailParamValidator.isValid(longEmail, context);
+		assertTrue(result);
+	}
+
+}
+
diff --git a/common/src/test/java/org/apache/hertzbeat/common/support/vaild/HostParamValidatorTest.java b/common/src/test/java/org/apache/hertzbeat/common/support/vaild/HostParamValidatorTest.java
new file mode 100644
index 00000000000..57d51eff86d
--- /dev/null
+++ b/common/src/test/java/org/apache/hertzbeat/common/support/vaild/HostParamValidatorTest.java
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hertzbeat.common.support.vaild;
+
+import jakarta.validation.ConstraintValidatorContext;
+import org.apache.hertzbeat.common.support.valid.HostParamValidator;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.when;
+
+/**
+ * Test case for {@link HostParamValidator}
+ */
+
+class HostParamValidatorTest {
+
+	@InjectMocks
+	private HostParamValidator hostParamValidator;
+
+	@Mock
+	private ConstraintValidatorContext context;
+
+	@Mock
+	private ConstraintValidatorContext.ConstraintViolationBuilder constraintViolationBuilder;
+
+	@BeforeEach
+	public void setUp() {
+		MockitoAnnotations.initMocks(this);
+		when(context.buildConstraintViolationWithTemplate(any())).thenReturn(constraintViolationBuilder);
+	}
+
+	@Test
+	public void testIsValid() {
+		boolean result = hostParamValidator.isValid(null, context);
+		assertFalse(result);
+
+		result = hostParamValidator.isValid("", context);
+		assertFalse(result);
+
+		result = hostParamValidator.isValid("   ", context);
+		assertFalse(result);
+
+		result = hostParamValidator.isValid("192.168.1.1", context);
+		assertTrue(result);
+
+		result = hostParamValidator.isValid("2001:0db8:85a3:0000:0000:8a2e:0370:7334", context);
+		assertTrue(result);
+
+		result = hostParamValidator.isValid("www.example.com", context);
+		assertTrue(result);
+
+		result = hostParamValidator.isValid("http://www.example.com", context);
+		assertTrue(result);
+
+		result = hostParamValidator.isValid("https://www.baidu.com", context);
+		assertTrue(result);
+
+		result = hostParamValidator.isValid("ht!tp://www.example.com", context);
+		assertFalse(result);
+	}
+}
+
diff --git a/common/src/test/java/org/apache/hertzbeat/common/support/vaild/PhoneNumParamValidatorTest.java b/common/src/test/java/org/apache/hertzbeat/common/support/vaild/PhoneNumParamValidatorTest.java
new file mode 100644
index 00000000000..6657770ddfc
--- /dev/null
+++ b/common/src/test/java/org/apache/hertzbeat/common/support/vaild/PhoneNumParamValidatorTest.java
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hertzbeat.common.support.vaild;
+
+import jakarta.validation.ConstraintValidatorContext;
+import org.apache.hertzbeat.common.support.valid.PhoneNumParamValidator;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.when;
+
+/**
+ * Test case for {@link PhoneNumParamValidator}
+ */
+
+class PhoneNumParamValidatorTest {
+
+	@InjectMocks
+	private PhoneNumParamValidator phoneNumParamValidator;
+
+	@Mock
+	private ConstraintValidatorContext context;
+
+	@Mock
+	private ConstraintValidatorContext.ConstraintViolationBuilder constraintViolationBuilder;
+
+	@BeforeEach
+	public void setUp() {
+		MockitoAnnotations.initMocks(this);
+		when(context.buildConstraintViolationWithTemplate(any())).thenReturn(constraintViolationBuilder);
+	}
+
+	@Test
+	public void testIsValid() {
+		boolean result = phoneNumParamValidator.isValid(null, context);
+		assertFalse(result);
+
+		result = phoneNumParamValidator.isValid("", context);
+		assertFalse(result);
+
+		result = phoneNumParamValidator.isValid("123456", context);
+		assertFalse(result);
+
+		result = phoneNumParamValidator.isValid("abc123", context);
+		assertFalse(result);
+
+		result = phoneNumParamValidator.isValid("13900001234", context);
+		assertTrue(result);
+
+		result = phoneNumParamValidator.isValid("1234567890123456789", context);
+		assertFalse(result);
+	}
+}
+