Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore collecting fetched bytes stats when sst file is read only once #1369

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

ShiKaiWi
Copy link
Member

Rationale

The stats about the number of bytes fetched from object store should not include the low-frequency reading, e.g. compaction because such stats are used to show the query load distribution across the tables.

Detailed Changes

Ignore collecting the fetched bytes stats in the low-frequency reading.

Test Plan

The ci's tests should pass.

Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit b5bfb2c into apache:dev Dec 15, 2023
7 checks passed
@ShiKaiWi ShiKaiWi deleted the ignore-compact-metrics branch December 15, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants