Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix broken link #1399

Merged
merged 4 commits into from
Dec 22, 2023
Merged

fix: fix broken link #1399

merged 4 commits into from
Dec 22, 2023

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Dec 22, 2023 •
edited by tanruixiang
Loading

Rationale

use available link

Detailed Changes

use available link

Test Plan

ut

@caicancai caicancai marked this pull request as draft December 22, 2023 08:35
@caicancai caicancai marked this pull request as ready for review December 22, 2023 08:36
@caicancai
Copy link
Member Author

caicancai commented Dec 22, 2023 •
edited
Loading

@tanruixiang I think it is more appropriate to use this for now, because the domain name does not seem to have been updated yet.
https://github.com/apache/incubator-horaedb-docs/blob/029e993f359907b7502b969a1cffeb8e43cb17fb/docs/src/en/dev/conventional_commit.md or https://apache.github.io/incubator-horaedb-docs/dev/conventional_commit.html

tanruixiang
tanruixiang approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@tanruixiang tanruixiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM.

@tanruixiang tanruixiang merged commit ab96579 into apache:main Dec 22, 2023
@caicancai caicancai deleted the broken_link branch December 22, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanruixiang tanruixiang tanruixiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caicancai @tanruixiang