Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix broken link #1399

Merged
merged 4 commits into from
Dec 22, 2023
Merged

fix: fix broken link #1399

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66bc6fb
fix: fix broken link
caicancai Dec 22, 2023
8723147
fix: fix broken link
caicancai Dec 22, 2023
155178c
fix: fix broken link
caicancai Dec 22, 2023
6815792
fix: fix broken link
caicancai Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ For features, we don't plan to support we will close the feature request ticket

## Contributing Changes

HoraeDB is written mostly in idiomatic Rust—please see the [Style Guide](https://horaedb.apache.org/docs/dev/style_guide.html) for more details.
HoraeDB is written mostly in idiomatic Rust—please see the [Style Guide](https://github.com/apache/incubator-horaedb-docs/blob/main/docs/src/en/dev/style_guide.md) for more details.
All code must adhere to the `rustfmt` format, and pass all of the `clippy` checks we run in CI (there are more details further down this README).

### Making a PR
Expand All @@ -38,7 +38,7 @@ PR title.

For PRs that you consider ready for review, verify the following locally before you submit it:

* you have a coherent set of logical commits, with messages conforming to the [Conventional Commits](https://horaedb.apache.org/docs/dev/conventional_commit.html) specification;
* you have a coherent set of logical commits, with messages conforming to the [Conventional Commits](https://github.com/apache/incubator-horaedb-docs/blob/029e993f359907b7502b969a1cffeb8e43cb17fb/docs/src/en/dev/conventional_commit.md) specification;
* all the tests and/or benchmarks pass, including documentation tests;
* the code is correctly formatted and all `clippy` checks pass; and
* you haven't left any "code cruft" (commented out code blocks etc).
Expand Down