Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exponential backoff when retry #1486

Merged
merged 9 commits into from
Feb 27, 2024

Conversation

zealchen
Copy link
Contributor

@zealchen zealchen commented Feb 21, 2024

Rationale

Add exponential backoff retry.

Detailed Changes

follow this backoff implementation.

Test Plan

New UT.

@jiacai2050
Copy link
Contributor

@zealchen CI fails.

@zealchen
Copy link
Contributor Author

@zealchen CI fails.

Solved.

src/components/future_ext/src/retry.rs Show resolved Hide resolved
src/components/future_ext/src/retry.rs Outdated Show resolved Hide resolved
src/components/future_ext/src/retry.rs Outdated Show resolved Hide resolved
src/components/future_ext/src/retry.rs Show resolved Hide resolved
src/analytic_engine/src/sst/file.rs Outdated Show resolved Hide resolved
@jiacai2050 jiacai2050 changed the title Feat exponential backoff feat: add exponential backoff when retry Feb 27, 2024
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit fb9f447 into apache:main Feb 27, 2024
9 checks passed
zealchen added a commit to zealchen/incubator-horaedb that referenced this pull request Apr 9, 2024
## Rationale

Add exponential backoff retry.

## Detailed Changes

follow
[this](https://github.com/apache/arrow-rs/blob/dfb642809e93c2c1b8343692f4e4b3080000f988/object_store/src/client/backoff.rs#L26)
backoff implementation.

## Test Plan

New UT.

---------

Co-authored-by: zealchen <chenmian428@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants