-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exponential backoff when retry #1486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add sst level config for benchmark
@zealchen CI fails. |
zealchen
force-pushed
the
feat_exponential_backoff
branch
from
February 24, 2024 06:01
69248b7
to
bef6c14
Compare
zealchen
force-pushed
the
feat_exponential_backoff
branch
from
February 24, 2024 06:20
bef6c14
to
767f00b
Compare
Solved. |
jiacai2050
reviewed
Feb 26, 2024
jiacai2050
changed the title
Feat exponential backoff
feat: add exponential backoff when retry
Feb 27, 2024
jiacai2050
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zealchen
added a commit
to zealchen/incubator-horaedb
that referenced
this pull request
Apr 9, 2024
## Rationale Add exponential backoff retry. ## Detailed Changes follow [this](https://github.com/apache/arrow-rs/blob/dfb642809e93c2c1b8343692f4e4b3080000f988/object_store/src/client/backoff.rs#L26) backoff implementation. ## Test Plan New UT. --------- Co-authored-by: zealchen <chenmian428@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Add exponential backoff retry.
Detailed Changes
follow this backoff implementation.
Test Plan
New UT.