Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failure to open a single table does not interrupt the shard's opening process #722

Merged
merged 11 commits into from
Mar 15, 2023

Conversation

MichaelLeeHZ
Copy link
Contributor

Which issue does this PR close?

Closes #721

Rationale for this change

The shard will stop opening if opening a table fails, and no other normal tables will be opened in that shard.
Access to these tables will fail.

What changes are included in this PR?

  • Print warn log if opening a table fails
  • Continue to open shard

Are there any user-facing changes?

How does this change test

@MichaelLeeHZ MichaelLeeHZ marked this pull request as ready for review March 10, 2023 05:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #722 (858c2e0) into main (11f10c2) will decrease coverage by 0.13%.
The diff coverage is 46.95%.

❗ Current head 858c2e0 differs from pull request most recent head b81ffed. Consider uploading reports for the commit b81ffed to get more accurate results

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   68.35%   68.22%   -0.13%     
==========================================
  Files         286      288       +2     
  Lines       44762    45350     +588     
==========================================
+ Hits        30596    30939     +343     
- Misses      14166    14411     +245     
Impacted Files Coverage Δ
analytic_engine/src/setup.rs 56.00% <0.00%> (-0.42%) ⬇️
server/src/config.rs 37.64% <0.00%> (-0.45%) ⬇️
server/src/grpc/meta_event_service/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/write.rs 37.32% <0.00%> (-1.67%) ⬇️
server/src/handlers/error.rs 0.00% <ø> (ø)
server/src/handlers/prom.rs 68.44% <0.00%> (-0.17%) ⬇️
server/src/handlers/query.rs 0.00% <0.00%> (ø)
server/src/http.rs 0.00% <0.00%> (ø)
... and 11 more

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chunshao90 chunshao90 changed the title Fix: Continue to open shard if opening a table fails fix: continue to open shard if opening a table fails Mar 12, 2023
server/src/grpc/meta_event_service/mod.rs Outdated Show resolved Hide resolved
server/src/grpc/meta_event_service/mod.rs Show resolved Hide resolved
server/src/grpc/meta_event_service/mod.rs Show resolved Hide resolved
server/src/grpc/meta_event_service/error.rs Outdated Show resolved Hide resolved
@chunshao90 chunshao90 changed the title fix: continue to open shard if opening a table fails fix: failure to open a single table does not interrupt the shard's opening process Mar 15, 2023
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 added this pull request to the merge queue Mar 15, 2023
Merged via the queue into apache:main with commit 509c2c3 Mar 15, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
…ening process (apache#722)

* continue to open shard when open table failed

* fmt

* romove unused lines

* Update server/src/grpc/meta_event_service/mod.rs

Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>

* add finsih log after open shard

* clippy

* return error when some tables failed to open

* add cost time

* log detail table error

* blank

* chore

---------

Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open shard failed because of OB_BUF_NOT_ENOUGH
4 participants