-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failure to open a single table does not interrupt the shard's opening process #722
Conversation
Codecov Report
@@ Coverage Diff @@
## main #722 +/- ##
==========================================
- Coverage 68.35% 68.22% -0.13%
==========================================
Files 286 288 +2
Lines 44762 45350 +588
==========================================
+ Hits 30596 30939 +343
- Misses 14166 14411 +245
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ening process (apache#722) * continue to open shard when open table failed * fmt * romove unused lines * Update server/src/grpc/meta_event_service/mod.rs Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com> * add finsih log after open shard * clippy * return error when some tables failed to open * add cost time * log detail table error * blank * chore --------- Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>
Which issue does this PR close?
Closes #721
Rationale for this change
The shard will stop opening if opening a table fails, and no other normal tables will be opened in that shard.
Access to these tables will fail.
What changes are included in this PR?
Are there any user-facing changes?
How does this change test