-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove compaction retry when memory limit #739
Merged
ShiKaiWi
merged 21 commits into
apache:main
from
MichaelLeeHZ:fix_delete_compaction_retry
Mar 15, 2023
Merged
fix: remove compaction retry when memory limit #739
ShiKaiWi
merged 21 commits into
apache:main
from
MichaelLeeHZ:fix_delete_compaction_retry
Mar 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>
…_retry # Conflicts: # .gitignore # server/src/config.rs # server/src/grpc/meta_event_service/mod.rs # server/src/grpc/mod.rs # server/src/grpc/storage_service/mod.rs # server/src/grpc/storage_service/write.rs # server/src/handlers/prom.rs # server/src/server.rs
ShiKaiWi
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* support auto create config * remove compaction retry * add table name in log * modify log * continue to open shard when open table failed * fmt * romove unused lines * Update server/src/grpc/meta_event_service/mod.rs Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com> * add finsih log after open shard * clippy * return error when some tables failed to open * add cost time * log detail table error * blank * chore * format log * remove compaction retry when memory limit --------- Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Compaction retry immediately when memory limit, result in lots of logs will prints.
What changes are included in this PR?
warn
Are there any user-facing changes?
None
How does this change test
None