From 96bf68fdf1ed38c46ee3b5039b5f795f22285660 Mon Sep 17 00:00:00 2001 From: gengxiaoyu Date: Mon, 16 May 2022 14:52:45 +0800 Subject: [PATCH] fix comments --- .../apache/hudi/common/config/HoodieMetastoreConfig.java | 2 +- .../hudi/common/table/view/FileSystemViewManager.java | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetastoreConfig.java b/hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetastoreConfig.java index e4073ba89f08..36e2798a4d32 100644 --- a/hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetastoreConfig.java +++ b/hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetastoreConfig.java @@ -22,7 +22,7 @@ import java.util.Properties; /** - * Configurations used by the HUDI Metadata Table. + * Configurations used by the HUDI Metastore. */ @Immutable @ConfigClassProperty(name = "Metastore Configs", diff --git a/hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java b/hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java index 72b44d542b48..35fda6c416ac 100644 --- a/hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java +++ b/hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java @@ -61,6 +61,8 @@ public class FileSystemViewManager { private static final Logger LOG = LogManager.getLogger(FileSystemViewManager.class); + private static final String HOODIE_METASTORE_FILE_SYSTEM_VIEW_CLASS = "org.apache.hudi.common.table.view.HoodieMetastoreFileSystemView"; + private final SerializableConfiguration conf; // The View Storage config used to store file-system views private final FileSystemViewStorageConfig viewStorageConfig; @@ -168,7 +170,7 @@ private static HoodieTableFileSystemView createInMemoryFileSystemView(HoodieMeta metadataSupplier.get()); } if (metaClient.getMetastoreConfig().enableMetastore()) { - return (HoodieTableFileSystemView) ReflectionUtils.loadClass("org.apache.hudi.common.table.view.HoodieMetastoreFileSystemView", + return (HoodieTableFileSystemView) ReflectionUtils.loadClass(HOODIE_METASTORE_FILE_SYSTEM_VIEW_CLASS, new Class[] {HoodieTableMetaClient.class, HoodieTimeline.class, HoodieMetastoreConfig.class}, metaClient, metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants(), metaClient.getMetastoreConfig()); } @@ -192,7 +194,7 @@ public static HoodieTableFileSystemView createInMemoryFileSystemViewWithTimeline return new HoodieMetadataFileSystemView(engineContext, metaClient, timeline, metadataConfig); } if (metaClient.getMetastoreConfig().enableMetastore()) { - return (HoodieTableFileSystemView) ReflectionUtils.loadClass("org.apache.hudi.common.table.view.HoodieMetastoreFileSystemView", + return (HoodieTableFileSystemView) ReflectionUtils.loadClass(HOODIE_METASTORE_FILE_SYSTEM_VIEW_CLASS, new Class[] {HoodieTableMetaClient.class, HoodieTimeline.class, HoodieMetadataConfig.class}, metaClient, metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants(), metaClient.getMetastoreConfig()); }