-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUPPORT]: Build failing on latest master on M1 mac due to protobuf support #6724
Comments
@codope @nsivabalan @the-other-tim-brown I see the changes were introduced in this PR - #6135. I tried few ways to fix this, but the error does not seem to resolve. This is actually hampering my other PRs where hudi-utilities module is getting modified. |
Looks like |
@the-other-tim-brown any workaround for this issue? |
As per this link - https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.17.3/, we have the .exe file for M1 mac. I tried degrading the protoc version to 3.17.3 and got the below error -
|
I see that there was a fix for m1 macs here https://github.com/apache/hudi/pull/6535/files. We can also try another popular proto plugin https://www.xolstice.org/protobuf-maven-plugin/ |
I just tried building on master and it worked for me. |
@jonvex which machine are you using? Is it an M1 mac? |
@jonvex You mention in this comment - #6535 (comment) that if processor is aarch64, what do you mean by that? Does it have anything to do with the java architecture as well? I would like to know the java version and architecture that you are using. I am actually using x86_64 java 8 as is visible in the output below -
Can this be the reason behind the build failing? |
I'm using an M1 mac. My java version is: |
Downloaded the arm64 java 8 from the link you suggested. The build still fails with the error -
|
i've double checked and it works on my computer and I can build latest master without issues.
please check Maven settings like enabled profiles - maybe you have some overwrites ? |
Maybe you have Rosseta installed and you use Java for x86 and not one dedicated to aarm64? Please paste Yours output of |
Here is the output - yes I have rosetta installed. |
please check output from plugin
|
Here is the output - [INFO] --- protoc-jar-maven-plugin:3.11.4:run (proto-compile) @ hudi-utilities_2.11 --- |
Yours output looks truncated - maybe yours proxy blocks downloading .zip .exe files? |
I have not made any changes to the intellij settings or .m2 settings.xml file. Let me try to see why https://repo.maven.apache.org/maven2 is getting converted to http://0.0.0.0 in my case. This is weird. |
I have been getting these warnings continuously before the build fails. Is this happening in your build as well @slachiewicz? [INFO] ----------------< org.apache.hudi:hudi-utilities_2.11 >----------------- |
I guess something else is wrong. I do not have any mirror specified in my settings.xml. So maven cannot pick any http repository for fetching the artifacts. |
@pratyakshsharma I can build the latest master on M1 Mac as well. Looks like dependency management is the issue for you.
Here are my versions:
|
Closing this as the issue is not related to Hudi. @pratyakshsharma feel free to post your solution once the build succeeds on your side. |
For now, the only way out is to skip the concerned classes from compiling. Need to dig deep further to see why maven tries to use http://0.0.0.0 to resolve protobuf dependencies in my case. |
The simple fix was removing the settings.xml file from |
i was able to run successful build locally without any customisations and with empty |
alright, this is what I wanted to know. Thank you for all the support @yihua @slachiewicz @codope @jonvex @the-other-tim-brown |
I also meet this problem😂. Thanks everyone below this issue. ERROR
Solution After I delete |
I added this to the protoc-jar-maven-plugin configuration in the hudi-kafka-connect module's pom.xml file: The < protocArtifact > com. Google. Protobuf: protoc: 3.21.5 < / protocArtifact >. Then recompiled Hudi source code, can be compiled through. |
when i complie flink-1.13.6 meeting the issue. finally, i solve the problem by the way: |
Tips before filing an issue
Have you gone through our FAQs? yes
Join the mailing list to engage in conversations and get faster support at dev-subscribe@hudi.apache.org.
If you have triaged this as a bug, then file an issue directly.
Describe the problem you faced
Tried building the latest master using the command
mvn clean install -DskipTests
. It fails with the below error -[ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (proto-compile) on project hudi-utilities_2.11: Error extracting protoc for version 3.21.5: Unsupported platform: protoc-3.21.5-osx-x86_64.exe -> [Help 1]
To Reproduce
Steps to reproduce the behavior:
mvn clean install -DskipTests
Expected behavior
Build should finish successfully.
The text was updated successfully, but these errors were encountered: