Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-3661] Flink async compaction is not thread safe when use watermark #7399

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

danny0405
Copy link
Contributor

Change Logs

The process function output collector is not thread safe, when the async executor in the CompactionFunction and the mailbox executor invokes the collector#output concurrently, the output buffer may corrupt.

In this PR, we replace the CompactFunction with a new CompactOperator within which the watermark events are ignored intentionally. The mailbox executor would expect to not modify the collector output buffer anymore.

Impact

Fix the concurremcy conflicts.

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@hudi-bot
Copy link

hudi-bot commented Dec 7, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit 86d1e39 into apache:master Dec 7, 2022
danny0405 added a commit to danny0405/hudi that referenced this pull request Dec 15, 2022
nsivabalan pushed a commit to danny0405/hudi that referenced this pull request Dec 16, 2022
nsivabalan pushed a commit that referenced this pull request Dec 16, 2022
fengjian428 pushed a commit to fengjian428/hudi that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants