-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support writing to a branch #306
Comments
The API to write to a branch should look something like
But in order to write to a branch, the branch needs to be created first. From https://iceberg.apache.org/docs/latest/spark-writes/#writing-to-branches:
|
First pass, just refactoring |
We first need a Then update places currently gated by
And finally add a test for writing to a branch |
also note iceberg-python/dev/provision.py Lines 146 to 148 in 9e03949
|
I had an offline chat with @kevinjqliu , I shall work on this to build off of the PR created by kevin. |
Hello, can I hop back on this train if no one else is actively working on this (again building off of kevin's work)? @kevinjqliu @Fokko |
@Gowthami03B definitely, I've assigned the issue to you! |
Opening up this to the community as I am gonna be out for the next month! @kevinjqliu |
@kevinjqliu @Fokko |
@vinjai yes! please go ahead. |
Hi @vinjai thank you very much for working on this issue. I'm just working through the list of open items to check if they are still actively being worked on. Are you still interested in contributing this feature to PyIceberg? 🧊 |
Hey @sungwy |
PR is ready for review |
Feature Request / Improvement
Right now we hardcoded that we write to the main branch all the time, would be great to make this configurable.
The text was updated successfully, but these errors were encountered: