Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rename ManifestListEntry, ManifestEntry to make them more similar to java/python implementation. #145

Closed
liurenjie1024 opened this issue Jan 4, 2024 · 2 comments
Closed

refactor: Rename ManifestListEntry, ManifestEntry to make them more similar to java/python implementation. #145

liurenjie1024 opened this issue Jan 4, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@liurenjie1024
Copy link
Collaborator 

          I'm confused by the naming, should this be a `ManifestFile`?

From the spec:

Manifest list files store manifest_file, a struct with the following fields

Originally posted by @Fokko in #129 (comment)
@liurenjie1024 liurenjie1024 changed the title refactor: Rename refactor: Rename ManifestListEntry, ManifestEntry to make them more similar to java/python implementation. Jan 4, 2024
@liurenjie1024 liurenjie1024 mentioned this issue Jan 4, 2024
Merged
@liurenjie1024 liurenjie1024 added the enhancement New feature or request label Jan 4, 2024
@s-akhtar-baig s-akhtar-baig mentioned this issue Feb 19, 2024
Merged
@s-akhtar-baig
Copy link
Contributor

Create changes in #204.

@liurenjie1024
Copy link
Collaborator Author

Close by #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liurenjie1024 @s-akhtar-baig