deletion: drop webdocket enable control in proxy-rewrite plugin #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a backwards incompatible modification and should be specifically noted in PR |
|
@lilien1010 please take a look at the output of CI |
membphis
approved these changes
Mar 24, 2020
|
@lilien1010 It is recommended to increase the version number of this plugin. |
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
…he#1332) * deletion: drop webdocket enable control in proxy-rewrite plugin * fix test-case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove websocket related code in proxy-rewrite plugin
since there is enable controller in the upstream module, there is no need to have websocket enable in this plugin.
And we need to mention this in the next release note
Notice:
the user need to transfer their websocket configuration from proxy-rewrite into upstream, if they enabled websocket proxy-rewrite plugin.
Full changelog
Issues resolved
Fix #1331