enhance: plugin Zipkin add service name and report local server IP #1386
+228
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
reviewed
Apr 2, 2020
once the server started, server_addr and server_port won't change, so we can cache it.
|
@lilien1010 travis CI broken, please take a look. |
|
@moonming It works fine now. |
membphis
approved these changes
Apr 3, 2020
moonming
requested changes
Apr 3, 2020
|
I think like local ip address `192.168.3.50` is ok
Thanks,
Ming Wen
Twitter: _WenMing
Lien <notifications@github.com> 于2020年4月3日周五 下午5:46写道：
… ***@***.**** commented on this pull request.
------------------------------
In doc/plugins/zipkin-cn.md
<#1386 (comment)>
:
> @@ -49,7 +51,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1
"plugins": {
"zipkin": {
"endpoint": "http://127.0.0.1:9411/api/v2/spans",
- "sample_ratio": 1
+ "sample_ratio": 1,
+ "service_name": "APISIX-IN-SG",
+ "server_addr": "8.8.8.8"
how about change it into 1.2.3.4
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1386 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJZBK7T3IGAAERYAXGP66DRKWV7VANCNFSM4LY4XAOQ>
.
|
moonming
approved these changes
Apr 8, 2020
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
allow zipkin to set servie name and local ip sddress so that we can track it in APM system
Full changelog