-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance bundled examples #3115
enhance bundled examples #3115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3115 +/- ##
============================================
- Coverage 63.52% 63.49% -0.03%
Complexity 75 75
============================================
Files 652 652
Lines 28183 28183
Branches 4791 4791
============================================
- Hits 17902 17895 -7
- Misses 8023 8030 +7
Partials 2258 2258
Continue to review full report at Codecov.
|
|
||
@Component("demoServiceComponent") | ||
public class DemoServiceComponent implements DemoService { | ||
@Reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any plan to use @Autoimport of sprint-boot or should we keep it @reference ?
* move dubbo xml demo into delegated dir * add demo for annotation usage, and rename dubbo-demo-api to dubbo-demo-interface * add pure api demo * enhance examples * remove useless imports * add readme for dubbo-demo
What is the purpose of the change
add more basic examples, including xml config, annotation config, and pure api, for easier debugging/self-verfication purpose.
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.