Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance bundled examples #3115

Merged
merged 6 commits into from
Jan 2, 2019
Merged

enhance bundled examples #3115

merged 6 commits into from
Jan 2, 2019

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Jan 2, 2019

What is the purpose of the change

add more basic examples, including xml config, annotation config, and pure api, for easier debugging/self-verfication purpose.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #3115 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3115      +/-   ##
============================================
- Coverage     63.52%   63.49%   -0.03%     
  Complexity       75       75              
============================================
  Files           652      652              
  Lines         28183    28183              
  Branches       4791     4791              
============================================
- Hits          17902    17895       -7     
- Misses         8023     8030       +7     
  Partials       2258     2258
Impacted Files Coverage Δ Complexity Δ
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 44.79% <0%> (-4.17%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.82% <0%> (-1.35%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 57.3% <0%> (-0.77%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (+2.17%) 0% <0%> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 71.42% <0%> (+3.57%) 0% <0%> (ø) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.88% <0%> (+4.7%) 0% <0%> (ø) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 85.36% <0%> (+4.87%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41408e...9c5a1a6. Read the comment docs.


@Component("demoServiceComponent")
public class DemoServiceComponent implements DemoService {
@Reference
Copy link
Contributor

@khanimteyaz khanimteyaz Jan 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any plan to use @Autoimport of sprint-boot or should we keep it @reference ?

@beiwei30 beiwei30 merged commit 1b8d952 into apache:master Jan 2, 2019
@beiwei30 beiwei30 deleted the examples-enhance branch January 2, 2019 12:38
khanimteyaz pushed a commit to khanimteyaz/incubator-dubbo that referenced this pull request Jan 18, 2019
* move dubbo xml demo into delegated dir

* add demo for annotation usage, and rename dubbo-demo-api to dubbo-demo-interface

* add pure api demo

* enhance examples

* remove useless imports

* add readme for dubbo-demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants