Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] ArrowWritableColumnVector support write to decimal #6961

Closed
jinchengchenghh opened this issue Aug 21, 2024 · 2 comments
Closed

[VL] ArrowWritableColumnVector support write to decimal #6961

jinchengchenghh opened this issue Aug 21, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jinchengchenghh
Copy link
Contributor

jinchengchenghh commented Aug 21, 2024

Arrow batch could convert to MutableColumnarBatchRow to write data, first, it will setNotNull which is not need in arrow, it only need to set the value directly, so we should mark the function setNotNull to do nothing instead of throwing exception.
And Arrow does not have API to write range of decimal bytes, so we only write the total bytes.

@jinchengchenghh jinchengchenghh added the enhancement New feature or request label Aug 21, 2024
@zhztheplayer zhztheplayer changed the title ArrowWritableColumnVector support write to decimal [VL] ArrowWritableColumnVector support write to decimal Aug 22, 2024
@zhztheplayer
Copy link
Member

Description is empty. Could you fill in it?

@jinchengchenghh
Copy link
Contributor Author

Added, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants