Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Large timestamp outside of range #7109

Open
ccat3z opened this issue Sep 4, 2024 · 3 comments
Open

[VL] Large timestamp outside of range #7109

ccat3z opened this issue Sep 4, 2024 · 3 comments
Labels
bug Something isn't working triage

Comments

@ccat3z
Copy link
Contributor

ccat3z commented Sep 4, 2024

Backend

VL (Velox)

Bug description

Timestamps that great then 32767 years without but do not overflow will be outside of range.

Seq(
  (1723240800675l)
).toDF("time")

spark.sql("""
  select from_unixtime(event_timestamp, 'HH') from test
""")

// vanilla: 56577-04-30 00:11:15
// gluten: Timestamp is outside of supported range of [-32767-01-01, 32767-12-31]

It may be because std::chrono::time_point is used in time conversion, which has range limitations.

Spark version

None

Spark configurations

No response

System information

No response

Relevant logs

No response

@ccat3z ccat3z added bug Something isn't working triage labels Sep 4, 2024
@zml1206
Copy link
Contributor

zml1206 commented Sep 4, 2024

Seems to be a known issue facebookincubator/velox#10641

@ccat3z
Copy link
Contributor Author

ccat3z commented Sep 4, 2024

Seems to be a known issue facebookincubator/velox#10641

It maybe not same issue, facebookincubator/velox#10641 still use std::chrono. But the expected result is 56577, which std::chrono not supported.

@ccat3z
Copy link
Contributor Author

ccat3z commented Sep 4, 2024

Seems to be a known issue facebookincubator/velox#10641

It maybe not same issue, facebookincubator/velox#10641 still use std::chrono. But the expected result is 56577, which std::chrono not supported.

I am trying to remove the dependency on std::chrono to get rid of the limitations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants