[GLUTEN-7325] [CH] add a config to enable turn off read json #7333
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
baibaichen
reviewed
Sep 26, 2024
| @@ -130,6 +130,12 @@ object CHBackendSettings extends BackendSettingsApi with Logging { | |||
|
|
|||
| val GLUTEN_AQE_PROPAGATEEMPTY: String = CHConf.prefixOf("aqe.propagate.empty.relation") | |||
|
|
|||
| val GLUTEN_ALLOW_READ_JSON: String = | |||
| GlutenConfig.GLUTEN_CONFIG_PREFIX + CHBackend.BACKEND_NAME + | |||
There was a problem hiding this comment.
use CHConf.runtimeSettings instead of GlutenConfig.GLUTEN_CONFIG_PREFIX + CHBackend.BACKEND_NAME+".runtime_settings"
|
@shuai-xu please add a ut |
|
Run Gluten Clickhouse CI |
3 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For json format, it's difficult to get exactly same result with vanila spark, so add a config to enable turn off native read json.
(Fixes: #7325)
How was this patch tested?
This patch was tested by manual tests.