Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade maven-artifact-plugin to a version that doesn't ban flatten-maven-plugin #1371

Open
pefernan opened this issue Jun 28, 2024 · 3 comments
Assignees
Labels
area:dependencies Dependency upgrade/update/migration type:enhancement Something that already exists needs to be improved

Comments

@pefernan
Copy link

pefernan commented Jun 28, 2024

kie-tools (as all our kie environment) uses an old version of the maven-artifact-plugin (3.4.1) which could be upgrade to a newer version (at this time 3.5.1).

3.4.1 has the inconvenience that doesn't allow having Reproducible Builds if maven-flatten-plugin is present, and required a configuring the maven-artifact-plugin to exclude it, see apache/incubator-kie-tools#2455.

As a part of this change we should remove the <pluginIssues> config and the not-reproducible-plugins.properties from @kie-tools/maven-base.

IMPORTANT: at this time maven-artifact-plugin (3.5.1) requires maven-quarkus-plugin to be upgraded to 3.9.0 which is not LTS, so only do this upgrade after upgrading the Quarkus version too.

@pefernan pefernan self-assigned this Jun 28, 2024
@pefernan pefernan converted this from a draft issue Jun 28, 2024
@pefernan pefernan added area:dependencies Dependency upgrade/update/migration type:enhancement Something that already exists needs to be improved labels Jun 28, 2024
@gitgabrio
Copy link

gitgabrio commented Jun 28, 2024

@pefernan @tiagobento
This is an extremely low priority, even with the 3.9.0 LTS, because

  1. it involve change modification overall our codebase
  2. it does not add - by itself - any value (unless we find out that is required by some other reasons)

Beside that, I would kindly ask anyone to stop creating "repo-specific" tickets for changes that should be cross-repo, as this one.

@gitgabrio gitgabrio changed the title Upgrade maven-artifact-plugin version to latest version in kie-tools Upgrade maven-artifact-plugin version to latest version Jun 28, 2024
@pefernan
Copy link
Author

pefernan commented Jun 28, 2024

@gitgabrio true. Just added it as a reminder to cleanup the reproducible build extra config I added in kie-tools

@tiagobento tiagobento changed the title Upgrade maven-artifact-plugin version to latest version Upgrade maven-artifact-plugin to a version that doesn't ban flatten-maven-plugin Jun 28, 2024
@tiagobento
Copy link

I think the value of this task is keeping our software up-to-date with the latest possible versions of the Maven toolchain. Keeping our own list of plugins that are known to not work for reproducible builds is a tech debt, and we might even get this upgrade for free when we move to Maven 4, for example. Who knows. Thanks for reporting it, great to have this mapped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Dependency upgrade/update/migration type:enhancement Something that already exists needs to be improved
Projects
Status: 🅿️ Parking Lot
Development

No branches or pull requests

3 participants