Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notice file in root of source release (10.0.0 - RC3) has wrong year in it #1618

Closed
Tracked by #1525
pjfanning opened this issue Nov 13, 2024 · 5 comments
Closed
Tracked by #1525
Assignees
Labels
apache:compliance Related to Apache compliance in terms of legal, governance, processes etc

Comments

@pjfanning
Copy link

I don't know where this file is in git.
Found at root level of apache-kie-10.0.0-incubating-sources.zip

https://dist.apache.org/repos/dist/dev/incubator/kie/10.0.0-rc3/

The year should include 2024.

Also all the listed dependencies - please remove them. These are not supposed to appear in a NOTICE file for source code. See #1616

Apache KIE
Copyright 2023 The Apache Software Foundation

This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).

The Initial Developer of some parts of the framework, which are copied from, derived from, or
inspired by KIE (Knowledge Is Everthing) group, is Red Hat, Inc (https://www.redhat.com/).
Copyright Red Hat, Inc. and/or its affiliates.. All Rights Reserved.

This product also includes the following third-party components:

* Twitter bootstrap version: 2.3.2
  Downloaded from: https://getbootstrap.com/
  License: Apache License v2.0 (just like OptaPlanner)

* jQuery version: 1.9.1
  Downloaded from: http://jquery.com/
  License: MIT (which can be used by Apache License v2.0 projects)

* google-code-pretty version: 4-Mar-2013
  Downloaded from: http://code.google.com/p/google-code-prettify
  License: Apache License v2.0 (just like OptaPlanner)

* jQuery version: 3.3.1
  Downloaded from: http://jquery.com/
  License: MIT - this is compatible with ASL 2.0: http://www.apache.org/legal/resolved.html#category-a

* jstree version: 3.3.5
  Downloaded from: https://www.jstree.com/
  License: MIT - this is compatible with ASL 2.0: http://www.apache.org/legal/resolved.html#category-a

* animate.css (http://daneden.me/animate)

   Copyright (c) 2016 Daniel Eden

* bootstrap (https://getbootstrap.com/)

   Copyright 2011-2019 Twitter, Inc.

* bootstrap-datepicker (https://github.com/smalot/bootstrap-datetimepicker)

   Copyright 2012 Stefan Petre

* bootstrap-select (http://silviomoreto.github.io/bootstrap-select)

   Copyright 2013-2017 bootstrap-select

* Context Dependency Injection (CDI)

   Copyright (C) 2009 The JSR-330 Expert Group

* connected (https://github.com/Vertispan/connected)

   Copyright (C) 2017 Vertispan

* Eclipse Modeling Framework (https://eclipse.dev/modeling/emf/)
		
   Copyright (C) Eclipse and contributors: Copyright (c) 2010 SAP AG

* Font Awesome (https://fontawesome.com/)

   Copyright Dave Gandy 2016. All rights reserved

* Google Web Toolkit (GWT) (https://www.gwtproject.org/)

   Copyright 2007 Google Inc.

* GWT Bootstrap 3 (https://github.com/gwtbootstrap3/gwtbootstrap3)

   Copyright (C) 2013 GwtBootstrap3

* highlight.js (https://highlightjs.org)

   Copyright (C) highlight.js

* Jakarta EE (https://jakarta.ee/)

   Copyright (C) Eclipse and contributors

* Java Enterprise Edition (https://www.oracle.com/java/technologies/java-ee-glance.html)

   Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights reserved.

* Java Standard Edition (https://www.oracle.com/java/technologies/java-se-glance.html)

   Copyright (c) 2005-2013 Oracle and/or its affiliates

* jQuery UI (http://jqueryui.com)

   Copyright jQuery Foundation

* libgdx (https://github.com/libgdx/libgdx)

   Copyright (c) 2008, Avian Contributors

* Lienzo (https://github.com/dikalo/lienzo-core)
		
   Copyright (c) 2017 Ahome' Innovation Technologies

* Respond.js (https://github.com/scottjehl/Respond)

   Copyright 2013 Scott Jehl

* SnakeYAML (https://bitbucket.org/snakeyaml/snakeyaml)

   Copyright (c) 2018, SnakeYAML

* wysihtml (https://github.com/Voog/wysihtml)

   Copyright (C) 2012-2016 XING AG, Voog and contributors

* lunr  2.3.9
  Downloaded from: https://lunrjs.com/
  License: MIT

* search-ui
  Downloaded from: https://gitlab.com/antora/antora-lunr-extension
  License: Mozilla Public License 2.0

@tkobayas
Copy link

tkobayas commented Dec 4, 2024

Hi @pjfanning , just a confirmation. We update the "year" in NOTICE to "2024". We will no longer need to increment the year after the first incubator release, correct?

@pjfanning
Copy link
Author

pjfanning commented Dec 4, 2024

@tkobayas the year should be updated to include 2025 when do a 2025 release - same for 2026, etc.

There is no reason not include 2023 too since KIE joined the Incubator last year (I think).

So the copyright could now be '2023-2024'.

@tkobayas
Copy link

tkobayas commented Dec 5, 2024

@pjfanning Thank you. I'll fix it to 2023-2024. Then, next year, it will be 2023-2025. ( for example, https://github.com/apache/commons-lang/blob/master/NOTICE.txt )

The rc4 build contains 2024 now. I hope it's not a blocker, because "Malformed NOTICE" is minor issue : https://issues.apache.org/jira/browse/LEGAL-469

@yesamer
Copy link

yesamer commented Dec 11, 2024

@tkobayas @jomarko I guess we can close this task, right?

@tkobayas
Copy link

@yesamer Ah, I think we need one more step. tools/zip-sources-files/NOTICE has to be updated in kogito-pipelines main. I can work on that tomorrow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apache:compliance Related to Apache compliance in terms of legal, governance, processes etc
Projects
None yet
Development

No branches or pull requests

5 participants