Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move main to maven.compiler.release -> 17 #3343

Closed
wmedvede opened this issue Dec 22, 2023 · 2 comments
Closed

Move main to maven.compiler.release -> 17 #3343

wmedvede opened this issue Dec 22, 2023 · 2 comments
Assignees

Comments

@wmedvede
Copy link
Contributor

Describe the bug

Guys, after moving main to quarkus 3.2.9.Final, where it's supposed that we are now in jdk-17, is there any reason for having this in kogito-runtimes?

<maven.compiler.release>11</maven.compiler.release>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>

see:

<maven.compiler.release>11</maven.compiler.release>

I can see some tests failing because of this, for example kogito-runtimes/quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-image-integration-test, when quarkus-container-image-jib picks a base image to build images, it'll pick a ubi8/openjdk-11-runtime as base image.

But we have generated code, for example, org/kie/api/definition/process/Process produced by drools, that is in java-17
in summary, these generated image will fail complaining about:

Caused by: java.lang.UnsupportedClassVersionError: org/kie/api/definition/process/Process has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0

note that drools now has:

<maven.compiler.release>17</maven.compiler.release>
<maven.compiler.source>${maven.compiler.release}</maven.compiler.source>
<maven.compiler.target>${maven.compiler.release}</maven.compiler.target>

https://github.com/apache/incubator-kie-drools/blob/0c0b3e5d6e1a02ed46f1c31de359ac876997834b/build-parent/pom.xml#L38

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Kogito version or git rev (or at least Quarkus version if you are using Kogito via Quarkus platform BOM)

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@mariofusco
Copy link
Contributor

@wmedvede that's for sure a leftover, if you have time please send a PR fixing it.

@wmedvede
Copy link
Contributor Author

This was fixed by:

#3344
apache/incubator-kie-kogito-apps#1944

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎯 Done in 🦉 KIE Podling Board Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants