Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflows built in SFCP namespace always use latest tag for builder image #486

Closed
domhanak opened this issue Jun 12, 2024 · 2 comments · Fixed by #487
Closed

Workflows built in SFCP namespace always use latest tag for builder image #486

domhanak opened this issue Jun 12, 2024 · 2 comments · Fixed by #487
Assignees
@ricardozanini

Comments

@domhanak
Copy link
Contributor

domhanak commented Jun 12, 2024 •
edited

Describe the bug

Problem seems to be rooted in SFCP not using values from:
ConfigMap of operator -> controllers_cfg.yaml
and just use the default builder configmap dockerfile.

Expected behavior

SFCP workflows use the builder image from controllers-config ConfigMap of operator -> controllers_cfg.yaml

Actual behavior

SFCP workflows use the builder image from builder configmap

How to Reproduce?

  1. Deploy SFP with JS and DI postgresql ephemeral

  2. Deploy SFCP in separate namespace and reference above SFP

  3. Create new SF-Greeting in the SFCP NS

  4. Check log of the build ->It will use <builder-image>:latest

  5. Create new SF-Greeting-2 in SFP NS

  6. Check log of the build -> it will use <budilder-image>:9.99.0

  7. Inspect NS where operator is runnning, find configmap of builder

  8. You can see there is a FROM <builder_image>:latest

  9. Change this line to some other image

  10. Repeat from point, but just restart the builds of the SF CR's

Output of uname -a or ver

No response

Golang version

No response

Operator-sdk version

No response

SonataFlow Operator version or git rev

No response

Additional information

No response
ricardozanini added a commit to ricardozanini/incubator-kie-kogito-serverless-operator that referenced this issue Jun 12, 2024
@ricardozanini
Fix apache#486 - Set the controller config to the default platform
68011d3 
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
@ricardozanini ricardozanini mentioned this issue Jun 12, 2024
Merged
2 tasks
@ricardozanini
Copy link
Member

@domhanak Actually, the SonataFlowClusterPlatform is a cluster resource, hence it does not have a namespace. What happened here is that the operator created a default SonataFlowPlatform in the namespace of the workflow SF-Greeting. This automatic created platform is missing the default configuration. Please check my PR, it fixed the issue.

@domhanak
Copy link
Contributor Author

@ricardozanini Yea apologies for that, what I meant is simply a new NS on a cluster that has SFCP set. Will take a look.

ricardozanini added a commit that referenced this issue Aug 6, 2024
@ricardozanini
Fix #486 - Set the controller config to the default platform (#487)
9204041 
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this issue Aug 6, 2024
@ricardozanini @rgdoliveira
Fix apache#486 - Set the controller config to the default platform (a…
6fcaa8c 
…pache#487)

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardozanini ricardozanini

Labels
None yet
Projects
🦉 KIE Podling Board
Status: 🎯 Done
Milestone
No milestone
2 participants
@ricardozanini @domhanak