Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-836] RNN Example for Scala #11753

Merged
merged 7 commits into from
Aug 21, 2018
Merged

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Jul 13, 2018

Description

This is the example written in new API in Scala. It include the following two tests:

This example also include a change on the DataDesc by defining a default settings for shape size = 2 in NT format

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Copy link
Member Author

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please skip these section from your code review as it did not change

@lanking520
Copy link
Member Author

Add download: #11866

@Roshrini
Copy link
Member

@yzhliu @nswamy Can you review this PR and approve it if ready? tracking this one for MXNet 1.3 release. Thanks!

@nswamy
Copy link
Member

nswamy commented Jul 30, 2018

I would like this PR to wait until we have #11844 is merged in so we make sure that DataDesc works with RNN & Bucketing moduel

@lanking520
Copy link
Member Author

So I think probably we cannot make this as 1.3 release for now @Roshrini.

@Roshrini
Copy link
Member

@nswamy @lanking520 Thanks for the update :)

@sandeep-krishnamurthy sandeep-krishnamurthy added Scala pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Aug 8, 2018
@lanking520 lanking520 changed the title [MXNET-531] RNN Example for Scala [MXNET-836] RNN Example for Scala Aug 16, 2018
Copy link
Contributor

@andrewfayres andrewfayres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Unfortunately github makes looking at this far more confusing than it should be.

@nswamy
Copy link
Member

nswamy commented Aug 21, 2018

@lanking520 thanks for fixing the RNN example, @andrewfayres Thanks for the review and yes indeed the whitespace/formatting changes make it hard to look at it.

@nswamy nswamy merged commit 38f80af into apache:master Aug 21, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
* initial fix for RNN

* add CI test

* add encoding format

* scala style fix

* update readme

* test char RNN works

* ignore the test due to memory leaks
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
* initial fix for RNN

* add CI test

* add encoding format

* scala style fix

* update readme

* test char RNN works

* ignore the test due to memory leaks
@lanking520 lanking520 deleted the example-rnn branch September 19, 2018 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-response PR is reviewed and waiting for contributor to respond Scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants