Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Infer dtype in SymbolBlock import from input symbol (v1.3.x) #13117

Merged
merged 13 commits into from
Nov 7, 2018

Conversation

lebeg
Copy link
Contributor

@lebeg lebeg commented Nov 5, 2018

Description

A port of #12412 to 1.3.x branch.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@lebeg lebeg requested a review from szha as a code owner November 5, 2018 18:20
@lebeg
Copy link
Contributor Author

lebeg commented Nov 5, 2018

@sandeep-krishnamurthy

@lebeg
Copy link
Contributor Author

lebeg commented Nov 5, 2018

@nswamy

@szha
Copy link
Member

szha commented Nov 5, 2018

A likely easier way to add the changes is to provide a list of commits that committers can cherry-pick. The branch CI will still be triggered after picking.

@lebeg
Copy link
Contributor Author

lebeg commented Nov 5, 2018

@szha I'm making sure that there are no conflicts by rebasing the changes to the branch. What has been added (for a changelog, for example) would be easier to track and review as well.

@anirudhacharya
Copy link
Member

anirudhacharya commented Nov 5, 2018

@mxnet-label-bot [pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Nov 6, 2018
@szha szha merged commit dc5c877 into apache:v1.3.x Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants