Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build): skip re-generating thrift and skip re-cmaking #1082

Merged
merged 5 commits into from
Jul 28, 2022

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Jul 27, 2022

#1053

this patch includes:

  1. skip re-generating thrift and re-cmaking if it's not the first build, or doesn't specify -c. It will save much time if you only modify a little code.
  2. add set -e for most of the shell scripts
  3. use python instead of shell to get local ip
  4. fix an error path to $ROOT/src/builder/src/server/test/config.ini in run.sh

@acelyc111 acelyc111 marked this pull request as ready for review July 27, 2022 07:57
@neverchanje
Copy link
Contributor

scripts/collector_table_counter_gen.py Remove this file if it is useless.

@empiredan empiredan merged commit 422cb2d into apache:master Jul 28, 2022
@acelyc111
Copy link
Member Author

scripts/collector_table_counter_gen.py Remove this file if it is useless.

OK, we'll do it later.

GehaFearless pushed a commit to GehaFearless/incubator-pegasus that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants