Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(license): add ignore file/path configs to .rat-excludes #1175

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Sep 27, 2022

#823

  • adds ignore file/path configs to .rat-excludes
  • adds missing license header

Summary output of apache-rat:

$ java -jar ../apache-rat-0.15.jar -d ./ -E ./.rat-excludes
Ignored 0 lines in your exclusion files as comments or empty lines.

*****************************************************
Summary
-------
Generated at: 2022-09-27T23:52:00+08:00

Notes: 3
Binaries: 14
Archives: 0
Standards: 1629

Apache Licensed: 1041
Generated Documents: 0

JavaDocs are generated, thus a license header is optional.
Generated files do not require license headers.

0 Unknown Licenses

*****************************************************

DISCLAIMER-WIP
.rat-excludes
apache-rat-0.13.jar
.rat-excludes
Copy link
Member Author

@acelyc111 acelyc111 Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I removed the last blank line to make apache-rat happy

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@56339c0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1175   +/-   ##
=========================================
  Coverage          ?   53.40%           
=========================================
  Files             ?       27           
  Lines             ?     2522           
  Branches          ?        0           
=========================================
  Hits              ?     1347           
  Misses            ?     1130           
  Partials          ?       45           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@empiredan empiredan merged commit a81a7c8 into apache:master Sep 28, 2022
acelyc111 added a commit to acelyc111/pegasus that referenced this pull request Sep 28, 2022
@empiredan empiredan mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants